Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make message hash compatible with decoded message #1993

Merged
merged 5 commits into from
Apr 30, 2024
Merged

feat: make message hash compatible with decoded message #1993

merged 5 commits into from
Apr 30, 2024

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Apr 30, 2024

Problem

It is convenient to use messageHash for end users against DecodedMessage as it is the version they get from Filter.

Solution

Make messageHash compatible with IDecodedMessage

@weboko weboko requested a review from a team as a code owner April 30, 2024 10:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 181.22 KB (+0.03% 🔺) 3.7 s (+0.03% 🔺) 12 s (-21.11% 🔽) 15.7 s
Waku Simple Light Node 181.3 KB (+0.09% 🔺) 3.7 s (+0.09% 🔺) 21.8 s (+74.41% 🔺) 25.4 s
ECIES encryption 23.08 KB (0%) 462 ms (0%) 6.4 s (+125.11% 🔺) 6.9 s
Symmetric encryption 22.55 KB (0%) 452 ms (0%) 6 s (+37.94% 🔺) 6.4 s
DNS discovery 72.42 KB (0%) 1.5 s (0%) 12.6 s (+6.74% 🔺) 14 s
Peer Exchange discovery 74.1 KB (0%) 1.5 s (0%) 8 s (-32.72% 🔽) 9.5 s
Local Peer Cache Discovery 67.64 KB (0%) 1.4 s (0%) 9 s (-22.49% 🔽) 10.3 s
Privacy preserving protocols 38.87 KB (0%) 778 ms (0%) 8.7 s (+7.75% 🔺) 9.5 s
Waku Filter 111.79 KB (+0.2% 🔺) 2.3 s (+0.2% 🔺) 11.5 s (-5.32% 🔽) 13.7 s
Waku LightPush 110.15 KB (0%) 2.3 s (0%) 14.9 s (+52.22% 🔺) 17.1 s
History retrieval protocols 110.74 KB (0%) 2.3 s (0%) 9.8 s (-32.58% 🔽) 12 s
Deterministic Message Hashing 7.25 KB (-0.54% 🔽) 145 ms (-0.54% 🔽) 1.4 s (+28.91% 🔺) 1.6 s

danisharora099
danisharora099 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@danisharora099 danisharora099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@weboko weboko merged commit e529335 into master Apr 30, 2024
10 checks passed
@weboko weboko deleted the weboko/message-hash branch April 30, 2024 13:37
@weboko weboko mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danisharora099 danisharora099 danisharora099 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weboko @danisharora099